Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Dockerfile using multi-stages for production and dev image #751

Open
wants to merge 5 commits into
base: 3.x
Choose a base branch
from
Open

Single Dockerfile using multi-stages for production and dev image #751

wants to merge 5 commits into from

Commits on Jun 25, 2024

  1. Define baseimage with arguments required in multiple stages 

    Change versions, add common paths

Keep drupal path

Fix comment
    @AlMaVizca
    AlMaVizca committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    72b6c61 View commit details
    Browse the repository at this point in the history

  2. Avoid repeating common path 

    Use common path on entrypoint
    @AlMaVizca
    AlMaVizca committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2bdec56 View commit details
    Browse the repository at this point in the history

  3. Refactor composer dependencies to create the production image 

    Use docker stages to install dependencies and simplify the building script.
Prepare production image while keeping compatibility with the development image.

Fix typo

Relocate arguments to improve cache

Make single line for each env definition

Remove composer home path

Avoid installing recommended packages
    @AlMaVizca
    AlMaVizca committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    838d740 View commit details
    Browse the repository at this point in the history

  4. Relocate php unit configuration

    @AlMaVizca
    AlMaVizca committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9088552 View commit details
    Browse the repository at this point in the history

  5. Merge development image into a single Dockerfile 

    Changes based on PR review
    @AlMaVizca
    AlMaVizca committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    343a841 View commit details
    Browse the repository at this point in the history