Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder and improve field rendering #847

Open
wants to merge 11 commits into
base: 3.x
Choose a base branch
from

Conversation

paul121
Copy link
Member

@paul121 paul121 commented May 16, 2024

This PR changes field weights for consistency and to improve their rendering in entity view pages. Even though the fields' form weights are changing, this PR should not be changing the order of any fields in forms because many fields are grouped into tabs of similar fields.

This PR also moves images to the bottom region and renders them in a simple flex container so that multiple images can be displayed horizontally in the same row and wrap to new rows as necessary (adjusts to screensize). I think this is a simple short-term optimization to displaying a potentially long vertical list of images all in the second region. It keeps images and files together and adds a field label for each.

Land asset before:

land-asset-before-1
land-asset-before-2

Land asset after:

land-asset-after-1
land-asset-after-2

Log before:

log-before-1

Log after:

log-after-1

@paul121 paul121 requested a review from mstenta May 16, 2024 19:07
@paul121
Copy link
Member Author

paul121 commented May 16, 2024

cc @Farmer-Eds-Shed @Fosten @mstenta hopefully this covers most of the simple field re-orderings we discussed on the dev call today...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant