Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state/props in all Tasks components #455

Closed
4 tasks done
jgaehring opened this issue Aug 24, 2021 · 3 comments
Closed
4 tasks done

Fix state/props in all Tasks components #455

jgaehring opened this issue Aug 24, 2021 · 3 comments

Comments

@jgaehring
Copy link
Member

jgaehring commented Aug 24, 2021

Once I've finished #454, I need to comb through the all the templates and scripts in these SFC's to fix references to properties on logs, assets, etc that have changed in 2.x. For example, log.done === true needs to be changed to log.status === 'done'.

@jgaehring
Copy link
Member Author

Remember to fix state and props in all corresponding menu bars, as well.

@jgaehring
Copy link
Member Author

I believe where TasksEdit.vue is concerned, I'm going to punt on several major features for the alpha release, which are a lot more involved than simple changing a few property names and values:

Right now, I really just want to get Field Kit Core's basic functionality down pat, so I know entities with basic attributes are being stored and synced properly. Details of the Tasks module itself, while vital for the beta release, are a little out of scope for the original goals I had for the alpha, which was really to make sure core and farmOS.js were working as expected.

Perhaps there's a more elegant way, but I'm just going to comment out those sections of the template for now, so I can pick up easily when I get to those issues in the beta milestone. I'll open issues for quantities and movements once I'm done with this basic prop/state stuff, just in case I figure out an easier way before then.

@jgaehring
Copy link
Member Author

After I'm done with TasksEdit, I need to go back to TasksAll and fix how assets and areas are mapped to log properties in the .mapIdsToAssets() and .mapTidsToAreas() methods. This logic should really be moved to the tasks computed property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant