Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable files and images on v1 #445

Merged
merged 2 commits into from May 20, 2021
Merged

Disable files and images on v1 #445

merged 2 commits into from May 20, 2021

Conversation

jgaehring
Copy link
Member

In response to #444, this PR will do 2 things:

  1. Remove the files field from all logs.
  2. Disable the ability to add images to any logs that have already been synced to the server. The images field will be stripped off logs before sending them to the server if a server-assigned id is present on the log.

Number 2 introduces a significant restriction of the images feature, but I think this is necessary until we overhaul images (#45), which will probably only be implemented in version 2.x. So this will be a permanent limitation in 1.x. Included in this PR is an explanation of why we're restricting this feature, which will be displayed on logs that have already been synced.

@mstenta
Copy link
Member

mstenta commented May 20, 2021

Tested this and it seems to fix the issue! I tested three scenarios:

  • Creating a log on the server with a file, pull into Field Kit, edit the Notes field, sync back - the file is untouched.
  • Creating a log on the server with a photo, same as above - file is untouched.
  • Creating a log in Field Kit with a photo - it syncs properly, and re-editing it does not touch the photo.

@jgaehring jgaehring merged commit e934c05 into v1 May 20, 2021
@jgaehring jgaehring deleted the v1-images branch May 20, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants