Add support for JSON functions in dashboard import #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-gerber
requested review from
cjwooo,
tovbinm and
ypc-faros
as code owners
chalenge
approved these changes
Apr 14, 2022
| ? value.replace(/<</g, '{{').replace(/>>/g, '}}') | ||
| // ->> and #>> must not be replaced | ||
| // https://www.postgresql.org/docs/9.4/functions-json.html | ||
| ? value.replace(/<</g, '{{').replace(/[^-#]>>/g, '}}') |
There was a problem hiding this comment.
maybe we should use some other chars?
There was a problem hiding this comment.
agreed, but that should be a different PR that will also add tests
cjwooo
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dashboard import incorrectly replaced some json operators (
#>>and->>). Those are now properly handled.See https://www.postgresql.org/docs/9.4/functions-json.html .
Fixes #106
Type of change
Checklist
(Delete what does not apply)