Metabase init always imports new dashboards #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified import methods
ypc-faros
approved these changes
May 6, 2022
tovbinm
reviewed
May 6, 2022
init/scripts/metabase-init.sh
Outdated
| fi | ||
|
|
||
| echo "Attached Faros database to Metabase" | ||
|
|
||
| echo "Importing dashboards" | ||
| node ../lib/metabase/init.js --metabase-url "$mb_url" --username "$mb_user" --password "$mb_password" --database "$db_name" --import-new |
tovbinm
reviewed
May 6, 2022
tovbinm
reviewed
May 6, 2022
init/src/metabase/config.ts
Outdated
| @@ -8,7 +8,7 @@ export interface Dashboard { | |||
| readonly template: string; | |||
| } | |||
|
|
|||
| export async function loadDashboards(): Promise<ReadonlyArray<Dashboard>> { | |||
| export async function loadDashboards(): Promise<Dashboard[]> { | |||
There was a problem hiding this comment.
what was wrong with ReadonlyArray<Dashboard>?
tovbinm
reviewed
May 6, 2022
init/src/metabase/dashboards.ts
Outdated
|
|
||
| for (const item of existingDashboards) { | ||
| existingDashboardNames.add(item.name); | ||
| this.logger.info('existing dashboard: %s', item.name); |
There was a problem hiding this comment.
this.logger.debug('Existing dashboard: %s', item.name)
tovbinm
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Metabase init always imports dashboards (
--import-newoption), but only non-existing ones.if one uses the
--import-oneoption, the name (with the extension) of a file existing inresources/metabase/dashboardsis expected. A new dashboard will be created (possibly a named duplicate) in the corresponding collection.Card behavior is unchanged: all cards needed by created dashboards will be added to the corresponding collection, possibly overwriting cards located them based on the name.
Fixes #136
Type of change
Checklist