Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the init container fail on any initialization failure #161

Merged
merged 1 commit into from
May 13, 2022
Merged

Conversation

ypc-faros
Copy link
Contributor

@ypc-faros ypc-faros commented May 12, 2022

Description

Make the init container fail on any initialization failure.

Scenarios verified:

  • Unreachable db, Airbyte, Hasura or Metabase webapps.
  • Error in Flyway migration (typo in a table name in a foreign key reference).
  • Error in Airbyte/Hasura/Metabase initialization scripts (I added a throw to the top of main)

Fixes #159 (I verified that docker-compose up exit code is 1 in my local. I expect the GHA to fail and hence stop the release)

Type of change

(Delete what does not apply)

  • New feature (non-breaking change which adds functionality)

Checklist

(Delete what does not apply)

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally before submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@thomas-gerber
Copy link
Contributor

  • Error in Airbyte/Hasura/Metabase initialization scripts (I added a throw to the top of main)

where is the throw?

@ypc-faros
Copy link
Contributor Author

  • Error in Airbyte/Hasura/Metabase initialization scripts (I added a throw to the top of main)

where is the throw?

That's what I did to tests what happens when the Typescript programs throw :)

@ypc-faros ypc-faros merged commit a09c289 into main May 13, 2022
@ypc-faros ypc-faros deleted the ypc/fail branch May 13, 2022 11:02
Copy link
Contributor

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Action shall fail if an init fails
3 participants