Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run builds on every PR change #166

Merged
merged 1 commit into from May 18, 2022
Merged

Run builds on every PR change #166

merged 1 commit into from May 18, 2022

Conversation

tovbinm
Copy link
Contributor

@tovbinm tovbinm commented May 18, 2022

Description

This to allow enabling branch protection. Since we require a Test to pass prior to merging for all contributions (including administrators), this change is necessary.

This to allow enabling branch protection
@tovbinm tovbinm changed the title Run builds on every change Run builds on every PR change May 18, 2022
@thomas-gerber
Copy link
Contributor

thomas-gerber commented May 18, 2022

Description

This to allow enabling branch protection

I do not think we need to run build on every PR to be comfortable with branch protection for admins. Indeed, if we are in a bind, an admin can always go to settings, allows admins to bypass branch protection, fix things.

That being said, running build on every PR may be a good idea in its own right. I am in favor of it.

@thomas-gerber
Copy link
Contributor

Description

This to allow enabling branch protection

I do not think we need to run build on every PR to be comfortable with branch protection for admins. Indeed, if we are in a bind, an admin can always go to settings, allows admins to bypass branch protection, fix things.

That being said, running build on every PR may be a good idea in its own right. I am in favor of it.

I misunderstood the description. This is only to run the existing PR workflow even if we only modify readme files, to allow merging PRs because of the check.

@thomas-gerber thomas-gerber merged commit 454de4b into main May 18, 2022
@thomas-gerber thomas-gerber deleted the tovbinm-patch-1 branch May 18, 2022 19:41
@tovbinm
Copy link
Contributor Author

tovbinm commented May 18, 2022

Since we require a Test to pass prior to merging for all contributions (including administrators), this change is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants