Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more endpoint tests #201

Merged
merged 4 commits into from Jul 13, 2022
Merged

Add more endpoint tests #201

merged 4 commits into from Jul 13, 2022

Conversation

ypc-faros
Copy link
Contributor

Description

Moves Hasura endpoint tests into a separate file.
Add tests for some endpoints. More to follow.

Checklist

(Delete what does not apply)

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally before submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Copy link
Contributor

@thomas-gerber thomas-gerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
you picked the endpoints that are hit by the Faros Event CLI, correct?

@ypc-faros
Copy link
Contributor Author

LGTM you picked the endpoints that are hit by the Faros Event CLI, correct?

Yes (for the ones that I've done so far). But there's no reason why not to test others.

@ypc-faros ypc-faros merged commit abed191 into main Jul 13, 2022
@ypc-faros ypc-faros deleted the ypc/endpoint_tests branch July 13, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants