Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only updates main airbyte sources on startup #257

Merged
merged 1 commit into from Nov 18, 2022
Merged

Conversation

thomas-gerber
Copy link
Contributor

Description

We update the sources we use in the CLI
We do NOT update the other sources at startup, those will use the version specified in the airbyte config, and the binaries will be downloaded when source config is saved.

Tradeoff is faster start, but we will need to regularly update versions for other connectors in our airbyte config.

Checklist

(Delete what does not apply)

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally before submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@tovbinm tovbinm merged commit 5e9b9c8 into main Nov 18, 2022
@tovbinm tovbinm deleted the fast_airbyte_setup branch November 18, 2022 23:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants