Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change syntax for patches #294

Merged
merged 1 commit into from May 5, 2023

Conversation

BrentSouza
Copy link
Contributor

@BrentSouza BrentSouza commented Apr 13, 2023

Description

The kustomization.yaml in kube/base has invalid syntax for patches which causes the following error when using kustomize >= 5.0.0:

invalid Kustomization: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal string into Go struct field Kustomization.patches of type types.Patch

This is a small change to add the proper syntax for patches in a file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

This works with kustomize >= 4.1.3 which is when replacements was added.

Checklist

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally before submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Copy link
Contributor

@thomas-gerber thomas-gerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-gerber thomas-gerber merged commit 02d25d2 into faros-ai:main May 5, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants