Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dupe configmap entry #306

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

BrentSouza
Copy link
Contributor

@BrentSouza BrentSouza commented Jul 18, 2023

Description

Hello team, looks like a key (JOB_ERROR_REPORTING_STRATEGY) was duplicated for the faros configmap, which is causing errors for deployment using kustomize. This just removes the new blank config entry in favor of the original.

Fixes #298

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally before submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Configuration entry for JOB_ERROR_REPORTING_STRATEGY is already present and causing errors

Signed-off-by: Brent Souza <brent.souza@gmail.com>
Copy link
Contributor

@thomas-gerber thomas-gerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrentSouza nice catch!
Could you do the same change on the main .env file in the root folder? We have a test that check those are the same to avoid drift.

Signed-off-by: Brent Souza <brent.souza@gmail.com>
@thomas-gerber thomas-gerber merged commit a8caa44 into faros-ai:main Jul 19, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configmap "faros-config" breaks Kustomize installation
2 participants