Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAI-8461 - Fix ts-jest deprecation warning #327

Merged
merged 2 commits into from
Nov 29, 2023
Merged

FAI-8461 - Fix ts-jest deprecation warning #327

merged 2 commits into from
Nov 29, 2023

Conversation

cjwooo
Copy link
Contributor

@cjwooo cjwooo commented Nov 28, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

(Delete what does not apply)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

(Delete what does not apply)

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally before submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@cjwooo cjwooo merged commit e62e15f into main Nov 29, 2023
2 checks passed
@cjwooo cjwooo deleted the cwu/8461 branch November 29, 2023 00:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
Copy link
Contributor

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kudos!!!

@cjwooo
Copy link
Contributor Author

cjwooo commented Nov 29, 2023

I stole the solution from @jeniii

@jeniii
Copy link

jeniii commented Nov 29, 2023

i update to "\\.[jt]sx?$" as it seems to be the default regex https://jestjs.io/docs/configuration#transform-objectstring-pathtotransformer--pathtotransformer-object
but it probably doesn't matter. just fyi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants