Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Commander in metabase init script #84

Merged
merged 1 commit into from Mar 28, 2022
Merged

Use Commander in metabase init script #84

merged 1 commit into from Mar 28, 2022

Conversation

ypc-faros
Copy link
Contributor

@ypc-faros ypc-faros commented Mar 28, 2022 •
edited by thomas-gerber

Description

Use Commander in metabase init script. Also passes the Faros database name via args.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally before submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@tovbinm
Copy link
Contributor

tovbinm commented Mar 28, 2022

Any scripts / docs to update?

@tovbinm tovbinm merged commit 8891681 into main Mar 28, 2022
@tovbinm tovbinm deleted the ypc/commander branch March 28, 2022 18:56
@ypc-faros
Copy link
Contributor Author

Any scripts / docs to update?

I think it was only metabase-init.sh

@tovbinm
Copy link
Contributor

tovbinm commented Apr 3, 2022

Please update the docs - https://community.faros.ai/docs/canned-dashboards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tovbinm tovbinm tovbinm approved these changes

@cjwooo cjwooo Awaiting requested review from cjwooo cjwooo is a code owner

@thomas-gerber thomas-gerber Awaiting requested review from thomas-gerber thomas-gerber is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ypc-faros @tovbinm