Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to override metabase db cfg values #93

Merged
merged 1 commit into from Apr 4, 2022
Merged

Conversation

ypc-faros
Copy link
Contributor

@ypc-faros ypc-faros commented Apr 4, 2022

Description

This change makes it possible to override the db host used to connect to the Faros db from Metabase and whether to use SSL.

After this change is merged, it'll be possible to remove the manual step here from the cloud deployment guide.

We need an extra env var (METABASE_FAROS_DB_HOST) because we still want FAROS_DB_HOST to point to the local host when initializing the cloud deployment, but we need for Metabase to point to the host within the cluster (i.e., the $PLURAL_METABASE_CLUSTERIP in our guide).

After the change is merged, these commands need to be updated (pass METABASE_FAROS_DB_HOST=$PLURAL_METABASE_CLUSTERIP and METABASE_USE_SSL=true) in the guide: 1 2

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally before submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@ypc-faros ypc-faros merged commit 8c1ca34 into main Apr 4, 2022
@ypc-faros ypc-faros deleted the ypc/metabase-dbcfg branch April 4, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants