Allows to override metabase db cfg values #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes it possible to override the db host used to connect to the Faros db from Metabase and whether to use SSL.
After this change is merged, it'll be possible to remove the manual step here from the cloud deployment guide.
We need an extra env var (
METABASE_FAROS_DB_HOST
) because we still wantFAROS_DB_HOST
to point to the local host when initializing the cloud deployment, but we need for Metabase to point to the host within the cluster (i.e., the$PLURAL_METABASE_CLUSTERIP
in our guide).After the change is merged, these commands need to be updated (pass
METABASE_FAROS_DB_HOST=$PLURAL_METABASE_CLUSTERIP
andMETABASE_USE_SSL=true
) in the guide: 1 2Type of change
Checklist