Fix retry handling for timeouts #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
eskrm
commented
Jan 18, 2023
eskrm
commented
Jan 18, 2023
| retryCondition: isRetryableError, | ||
| retryCondition: (error) => { | ||
| // Timeouts should be retryable | ||
| return error.code === 'ECONNABORTED' || isRetryableError(error); |
There was a problem hiding this comment.
Timeout errors due to config.timeout aren't considered retryable by isRetryableError(Error).
There was a problem hiding this comment.
do we use isRetryableError elsewhere - should we wrap this into our own isRetryableError function so it can be reused?
There was a problem hiding this comment.
https://github.com/search?q=org%3Afaros-ai+isRetryableError&type=code
We do use it in other places, but I think it's triggered in combination with a client side timeout. Otherwise we'll just get a 504 and retry.
ypc-faros
approved these changes
Jan 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.