Skip to content

Commit

Permalink
style(notification-container): Remove unnecessary white space (#204)
Browse files Browse the repository at this point in the history
- Fix class set on wrong element causing unnecessary white space

Closes #113.
  • Loading branch information
dominique-mueller committed Mar 11, 2021
1 parent 8a2a0eb commit 29e3c03
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<ul>
<li class="notifier__container-list" *ngFor="let notification of notifications; trackBy: identifyNotification">
<ul class="notifier__container-list">
<li class="notifier__container-list-item" *ngFor="let notification of notifications; trackBy: identifyNotification">
<notifier-notification [notification]="notification" (ready)="onNotificationReady($event)" (dismiss)="onNotificationDismiss($event)">
</notifier-notification>
</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ describe('Notifier Container Component', () => {
type: 'SHOW',
});
componentFixture.detectChanges();
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

expect(listElements.length).toBe(1);

Expand Down Expand Up @@ -353,7 +353,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

expect(listElements.length).toBe(0);
expect(mockNotificationComponent.hide).toHaveBeenCalled();
Expand Down Expand Up @@ -397,7 +397,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

expect(listElements.length).toBe(1);
expect(mockNotificationComponent.hide).not.toHaveBeenCalled();
Expand Down Expand Up @@ -454,7 +454,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(1);
Expand Down Expand Up @@ -512,7 +512,7 @@ describe('Notifier Container Component', () => {
tick(testNotifierConfig.animations.hide.speed);
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(1);
Expand Down Expand Up @@ -566,7 +566,7 @@ describe('Notifier Container Component', () => {
tick(testNotifierConfig.animations.hide.speed - <number>testNotifierConfig.animations.overlap);
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(1);
Expand Down Expand Up @@ -607,7 +607,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges();

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 2;
expect(listElements.length).toBe(0);
Expand Down Expand Up @@ -665,7 +665,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(1);
Expand Down Expand Up @@ -744,7 +744,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(1);
Expand Down Expand Up @@ -824,7 +824,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(0);
Expand Down Expand Up @@ -876,7 +876,7 @@ describe('Notifier Container Component', () => {
tick(testNotifierConfig.animations.hide.speed + numberOfNotifications * <number>testNotifierConfig.animations.hide.offset);
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(0);
Expand Down

0 comments on commit 29e3c03

Please sign in to comment.