Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No lyrics found" even when the lyrics are available in lrclib.net #1675

Closed
aneesh1122 opened this issue Apr 28, 2024 · 14 comments
Closed

"No lyrics found" even when the lyrics are available in lrclib.net #1675

aneesh1122 opened this issue Apr 28, 2024 · 14 comments
Labels
bug Something isn't working Fixed

Comments

@aneesh1122
Copy link

aneesh1122 commented Apr 28, 2024

Steps to reproduce the bug

  1. Open this in RiMusic
  2. Enable lyrics (shows that the lyrics are not available)
  3. Select Pick from Lrclib.net
  4. App says "No lyrics found"

Expected behavior

Lyrics should appear. The lyrics are available in lrclib.net

Check it yourself
Here

Actual behavior

Lyrics doesn't appear

Screenshots/Screen recordings

No response

Logs

No response

RiMusic version

0.6.32

Android version

Android 13

Additional information

Lyrics appear easily in another music app I use which also takes lyrics from lrclib

@aneesh1122 aneesh1122 added the bug Something isn't working label Apr 28, 2024
@AquamarineDreams
Copy link

I had this issue before #1433 and I'm having the same issue again. I have no idea what causes this because it doesn't seem to affect other users.

@aneesh1122
Copy link
Author

I had this issue before #1433 and I'm having the same issue again. I have no idea what causes this because it doesn't seem to affect other users.

Didn't you say it was working for you back then?

btw could you please try my link and see if lyrics are showing or not.

@AquamarineDreams
Copy link

Yes, I said it. For some reason it started working again after a few days, but today it stopped working again.

Sorry bro, but neither YouTube music or Rimusic found your song. Are you sure you typed the link correctly?

@AquamarineDreams
Copy link

Found the music. My client also couldn't find the synced lyrics.

@fast4x
Copy link
Owner

fast4x commented May 1, 2024

Reproduced, I'll fix it, thanks.

@fast4x fast4x added the Fixed label May 2, 2024
@fast4x
Copy link
Owner

fast4x commented May 2, 2024

Fixed, available from version 0.6.33

fast4x added a commit that referenced this issue May 3, 2024
@aneesh1122 aneesh1122 reopened this May 4, 2024
@aneesh1122
Copy link
Author

Hey @fast4x the lyrics are not appearing even in the latest version

VID_20240504_113245.mp4

@fast4x
Copy link
Owner

fast4x commented May 4, 2024

Screenrecorder-2024-05-04-08-58-44-885.mp4

@fast4x
Copy link
Owner

fast4x commented May 4, 2024

if your lyrics is present in LrcLib it will be found
https://github.com/fast4x/RiMusic/assets/1484476/8fa2f40f-699f-447f-b49b-b84f91ba36a2

@fast4x fast4x closed this as completed May 4, 2024
@aneesh1122
Copy link
Author

aneesh1122 commented May 4, 2024

Screenrecorder-2024-05-04-08-58-44-885.mp4

Your spelling is wrong. The correct spelling is "Thumkeshwari"😅

See this

327931483-a1976b83-b4cc-4bd0-a571-74e56924d7dc.mp4

@fast4x
Copy link
Owner

fast4x commented May 4, 2024

oh oh ok 😂😂

@AquamarineDreams
Copy link

@aneesh1122

Found your problem. The music name needs to match the one in lrclib.net.

MP4_20240504_100004VLOG.mp4

Hope that helps

@aneesh1122
Copy link
Author

@aneesh1122

Found your problem. The music name needs to match the one in lrclib.net.

MP4_20240504_100004VLOG.mp4

Hope that helps

The title actually has a result in lrclib.
https://github.com/fast4x/RiMusic/assets/45353488/f5f22bd1-0eba-4060-9297-1ff5d8bb4b2d

I think it takes the combination of 'Title' + 'artists' and matches the song. This works most of the times but sometimes it doesn't.

Anyways, this problem will be solved when @fast4x implements that searching box so there's nothing to worry about.

@aneesh1122
Copy link
Author

aneesh1122 commented May 4, 2024

oh oh ok 😂😂

you can solve this lyrics problem by doing this

  1. first search with 'title' 'artists'
  2. if above doesn't give any results, search only 'title'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed
Projects
None yet
Development

No branches or pull requests

3 participants