-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify init to pull the collect_env libraries #1994
Conversation
This will allow somebody to the show_install function with `from fastai.utils import *` instead of needing to remember that it is in collect_env
Seems consistent with the rest of what we have. @stas00 any reason not to do this? |
I have no objection, but if you do that, please adjust the docs, otherwise only you will know that there is a different way. |
Would you mind adding the proper documentation in this PR @kevinbird15 ? |
Sure, I will get that added today sometime. |
Just to clarify, there is only a need to edit the existing docs:
Thank you. |
Ok, so would you change it to just be fastai.utils and remove the collect_env part then or just note that there is another way to do it? So for each of these:
|
Remove the need for .collect_env from docs as this actually works with just fastai.utils at this point.
Remove the need for .collect_env from docs as this actually works with just fastai.utils at this point.
Remove the need for .collect_env from docs as this actually works with just fastai.utils at this point.
Remove the need for .collect_env from docs as this actually works with just fastai.utils at this point.
Ok, probably terrible practice, but I added commits to change these docs. I would have rather put all of the commits into one file, but I did it with the online edit file functionality. It seems like it worked ok, but I would figure out how to do it on my local version next time and push the changes up instead. Quick and dirty won me over this time though |
We don't mind quick and dirty, I know how painful it can be to checkout your PR branch and add commits when not used to git :) |
FYI, it's trivial to do if you use fastai-make-pr-branch. It does all the work for you. |
This will allow somebody to the show_install function with
from fastai.utils import *
instead of needing to remember that it is in collect_envHere is the forum thread discussing this change: https://forums.fast.ai/t/show-install-modification-suggestion/44214