Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the Model section of the lesson7-CAM work #638

Merged
merged 1 commit into from
Jul 19, 2018
Merged

make the Model section of the lesson7-CAM work #638

merged 1 commit into from
Jul 19, 2018

Conversation

stas00
Copy link

@stas00 stas00 commented Jul 18, 2018

  • fix the mismatch of 12 layer groups and lrs
  • fix the accuracy_np code which expected non-log input

for discussion see:
http://forums.fast.ai/t/lesson7-cam-mismatch-between-of-lrs-and-of-layer-groups/19425

- fix the mismatch of 12 layer groups and lrs
- fix the accuracy_np code which expected non-log input
@jph00 jph00 merged commit d402c7f into fastai:master Jul 19, 2018
@stas00
Copy link
Author

stas00 commented Jul 19, 2018

@jph00, could you also please address why the 3 -> 12 lrs "broadcasting" doesn't work here, perhaps in this thread:

http://forums.fast.ai/t/lesson7-cam-mismatch-between-of-lrs-and-of-layer-groups/19425

@jph00
Copy link
Member

jph00 commented Jul 19, 2018

@stas00 absolutely. Sorry about that - I haven't been coding for the last few months due to medical issues at home, so not surprised to hear that some notebooks have gotten out of sync with the PRs coming in. I'm back at work now so feel free to reach out directly if I miss anything. I'll ask @sgugger to look at this one.

@sgugger
Copy link
Contributor

sgugger commented Jul 19, 2018

I have to review the notebook but I guess it would be better to define a proper layer_groups at the model level than pass 12 learning rates. I'll get on it later today.

@stas00
Copy link
Author

stas00 commented Jul 19, 2018

Thank you, @jph00 and @sgugger, for working on that!

@stas00 stas00 deleted the lesson7-cam branch July 19, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants