Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to GitHub docs #136

Merged
merged 2 commits into from
Jul 23, 2022
Merged

Fix links to GitHub docs #136

merged 2 commits into from
Jul 23, 2022

Conversation

hwine
Copy link
Contributor

@hwine hwine commented May 19, 2022

Apparently, GitHub docs were changed to assume a default doc version
of 'free-pro-team@latest', and droped support for specifying that
explicitly.

Additionally, remove the '/en' locale specifier, so the browser can
negotiate the appropriate one for every user.

Changes were done mechanically using

for f in $(rg '@latest' -l) ; do
    sed --in-place=.doc \
        -e 's:docs.github.com/en/free-pro-team@latest/:docs.github.com/:g' \
        $f
done

N.B. the CONTRIBUTING.md section on documentation changes appears to reference an older procedure. Please let me know if a different procedure should be used now.

Fixes #135

Apparently, GitHub docs were changes to _assume_ a default doc version
of 'free-pro-team@latest', and drop support for specifying that
explicitly.

Additionally, remove the '/en' locale specifier, so the browser can
negotiate the appropriate one for every user.

Changes were done mechanically using
```bash
for f in $(rg '@latest' -l) ; do
    sed --in-place=.doc \
        -e 's:docs.github.com/en/free-pro-team@latest/:docs.github.com/:g' \
        $f
done
```
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jph00 jph00 merged commit aa834d0 into fastai:master Jul 23, 2022
@jph00
Copy link
Member

jph00 commented Jul 23, 2022

Many thanks!

@jph00 jph00 added the bug Something isn't working label Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README has many broken URLs
2 participants