Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to find notebooks recursively #359

Merged
merged 8 commits into from
Jan 6, 2021
Merged

add ability to find notebooks recursively #359

merged 8 commits into from
Jan 6, 2021

Conversation

hamelsmu
Copy link
Member

@hamelsmu hamelsmu commented Dec 30, 2020

Closes #358

Note: I made sure that .ipynb_checkpoints is ignored by ignoring all paths that contain the substring /., which ignores all hidden directories.

Ready for review: @jph00

This also partially related to #357.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hamelsmu hamelsmu requested a review from jph00 December 30, 2020 06:50
@jph00
Copy link
Member

jph00 commented Dec 30, 2020

This should be optional and default to false, since otherwise it's a breaking change

@hamelsmu
Copy link
Member Author

ok @jph00 ready for review. I made the following changes

  • made recursive search optional
  • updated the nbdev_build_lib CLI interface (I forgot to do that previously for some reason)
  • moved the notebook glob search to its own function
  • Updated tests in showdoc that incidentally use this function to test something else about showing the signature

cc: @muellerzr

@jph00 jph00 added the enhancement New feature or request label Dec 30, 2020
@hamelsmu
Copy link
Member Author

@jph00 made changes you requested

@jph00 jph00 merged commit ad9115a into master Jan 6, 2021
@jph00 jph00 deleted the recurse branch January 6, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow for recursive modules
2 participants