Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbdev_new: get template from latest release asset #382

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

hamelsmu
Copy link
Member

@hamelsmu hamelsmu commented Jan 17, 2021

Changes made

  • Instead of files.fast.ai, we get nbdev template files from the latest release asset files of fastai/nbdev_template
  • Get branch name from the github api

I tested this locally with multiple scenarios (new repos, existing repo, when files are present, when they aren't present, etc).

closes #383

@jph00 ready for review

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hamelsmu hamelsmu requested a review from jph00 January 17, 2021 02:37
@hamelsmu hamelsmu changed the title get template from latest release asset nbdev_new: get template from latest release asset Jan 17, 2021
@jph00 jph00 merged commit 1e2aff4 into master Jan 17, 2021
@jph00 jph00 deleted the nbdev_new-from-template-release branch January 17, 2021 02:41
@hamelsmu hamelsmu added the enhancement New feature or request label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbdev_new should grab files from a release asset in nbdev_template
2 participants