Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating ItemEntity with zero procent VAT #29

Closed
jbrouns opened this issue Oct 20, 2020 · 2 comments
Closed

Creating ItemEntity with zero procent VAT #29

jbrouns opened this issue Oct 20, 2020 · 2 comments

Comments

@jbrouns
Copy link

jbrouns commented Oct 20, 2020

It is not possible to create an ItemEntity with a vatPercent of 0.

Now the result gives this error:
Uncaught FastBillSdk\Common\MissingPropertyException: The property vatPercent is not valid!

According to https://apidocs.fastbill.com/fastbill/en/invoice.html#invoice.create the VAT_PERCENT is required.
But when I comment out the required property checks in the SDK, the API accepts the value of 0.

I think there are cases when 0 is a valid option (no tax is applied for transactions outside of EU for example)

What is your opinion?

Best regards,
Julien

teiling88 added a commit to teiling88/fastbill-sdk-php that referenced this issue Oct 24, 2020
teiling88 added a commit to teiling88/fastbill-sdk-php that referenced this issue Oct 24, 2020
teiling88 added a commit that referenced this issue Oct 24, 2020
@teiling88
Copy link
Collaborator

Hey @jbrouns,
I fixed that and created the Version 0.0.9 which includes the patch :-)

@jbrouns
Copy link
Author

jbrouns commented Oct 24, 2020

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants