-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating ItemEntity with zero procent VAT #29
Comments
teiling88
added a commit
to teiling88/fastbill-sdk-php
that referenced
this issue
Oct 24, 2020
teiling88
added a commit
to teiling88/fastbill-sdk-php
that referenced
this issue
Oct 24, 2020
teiling88
added a commit
that referenced
this issue
Oct 24, 2020
NTR - allow 0 for vat percentage #29
Hey @jbrouns, |
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is not possible to create an ItemEntity with a vatPercent of 0.
Now the result gives this error:
Uncaught FastBillSdk\Common\MissingPropertyException: The property vatPercent is not valid!
According to https://apidocs.fastbill.com/fastbill/en/invoice.html#invoice.create the VAT_PERCENT is required.
But when I comment out the required property checks in the SDK, the API accepts the value of 0.
I think there are cases when 0 is a valid option (no tax is applied for transactions outside of EU for example)
What is your opinion?
Best regards,
Julien
The text was updated successfully, but these errors were encountered: