Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registering plugins inside after should trigger override #116

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Registering plugins inside after should trigger override #116

merged 1 commit into from
Jul 12, 2020

Conversation

mcollina
Copy link
Member

Fixes fastify/fastify#2406

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • commit message and code follows Code of conduct

@mcollina mcollina requested review from delvedor and Eomm July 12, 2020 17:48
delvedor
delvedor approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fun one!

@mcollina mcollina merged commit 2d307a7 into master Jul 12, 2020
@delvedor delvedor mentioned this pull request Jul 14, 2020
Open
@Fdawgs Fdawgs deleted the ovveride-in-after branch August 10, 2022 06:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

@Eomm Eomm Awaiting requested review from Eomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fastify v3 register() scope seems to be wrong?
2 participants
@mcollina @delvedor