Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hono #318

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Add Hono #318

merged 2 commits into from
Nov 10, 2023

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Nov 9, 2023

Hono seems a good framework to add to the benchmark lists. It has 40k weekly downloads!

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@RafaelGSS RafaelGSS merged commit 2198f62 into master Nov 10, 2023
14 checks passed
@yusukebe
Copy link
Contributor

Hi @mcollina!

I'm the creator of Hono. Thank you for adding Hono to your list. However, I'd like to mention an important point, although you might already be aware of it. I think it's not necessary to include this in the README or anywhere else.

Hono is entirely based on Web-standard APIs. It's fast on platforms like Cloudflare Workers, Deno, and Bun. However, Hono cannot run natively on Node.js. It relies on a Node server adapter to convert Node.js's IncomingMessage/OutgoingMessage to and from the Web standards' Request/Response. This conversion introduces a significant overhead, and naturally, it leads to reduced performance on Node.js.

I knew this limitation, and I also recognize Fastify is super fast. I don't want to fight :)

Nevertheless, it's beneficial for users to understand the performance benchmarks of these frameworks, particularly in the context of Node.js.

Thank you!

@mcollina
Copy link
Member Author

Noted! The reason I added this was to check Hono performance, as quite a few people asked me how it performed on Node.js. Given its popularity, I thought adding to this table would make sense. But I'm ok it you want to remove it.

@yusukebe
Copy link
Contributor

Thank you! I'd like to take some time to consider whether to remove it or not. I'll let you know if we want to remove it.

By the way, it's interesting to note that Hono performs faster on Node.js 20 than on Node.js 18. I think that the Web-standard APIs in Node.js are improving. This is a great thing!

@francelwebdev
Copy link

HI @mcollina ,

Check this : https://nhttp.deno.dev/

@mcollina
Copy link
Member Author

Thank you! I'd like to take some time to consider whether to remove it or not. I'll let you know if we want to remove it.

By the way, it's interesting to note that Hono performs faster on Node.js 20 than on Node.js 18. I think that the Web-standard APIs in Node.js are improving. This is a great thing!

I’m part of the team working on them ;).

@jsumners jsumners deleted the add-hono branch November 11, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants