Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks for busboy #40

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Benchmarks for busboy #40

merged 3 commits into from
Nov 30, 2021

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Nov 30, 2021

Tadaaa!

I modified the dicer benchmark for busboy. I also added the old busboy for comparison, but i did not add a npm package.json script for benching against the old busboy. I can add it if you like.

I moved the dicer benchmarks into the bench folder. Looks clear. ;)

Checklist

}
}),
mb = 100,
buffer = createMultipartBuffer(boundary, mb * 1024 * 1024),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably should extract shared part somewhere to reduce risk of benchmarks diverging over time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Fastify-Busboy and Old-Busboy?

Copy link
Member

@kibertoad kibertoad Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the very least, but I assume there is lots of duplication across all benchmarks (which we'll need to revise eventually too).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do it in another PR? Benchmarks against other Projects has to be any way cleaned up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 30, 2021

btw. The comparison:

uzlopak@uzlopak-Lenovo-Legion-5-17ARH05H:~/Workspace/fastify/busboy$ node ./bench/busboy-bench.js 
2380.95 mb/sec
2222.22 mb/sec
3448.28 mb/sec
3571.43 mb/sec
3571.43 mb/sec
3448.28 mb/sec
3448.28 mb/sec
3571.43 mb/sec
3571.43 mb/sec
3448.28 mb/sec

uzlopak@uzlopak-Lenovo-Legion-5-17ARH05H:~/Workspace/fastify/busboy$ node ./bench/fastify-busboy-bench.js 
8333.33 mb/sec
11111.11 mb/sec
10000.00 mb/sec
10000.00 mb/sec
10000.00 mb/sec
10000.00 mb/sec
11111.11 mb/sec
11111.11 mb/sec
10000.00 mb/sec
10000.00 mb/sec

@Uzlopak Uzlopak merged commit d385e48 into fastify:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants