fix empty part bug, 2nd try

[Uzlopak]

@ruur
@kibertoad

Lets talk about the empty part bug here.

I use a simpler test than in the original PR. As you can see, it doesnt throw an error, despite it should throw an "Uncaught AssertionError: Parsed result count mismatch. Saw 4. Expected: 3: expected 4 to deeply equal 3"

If you uncomment the part in Dicer.js, you will see that it will then throw the expected AssertionError. Then you uncomment that line in the unit test, and it will become green.

I could not create a red phase, because it is like @ruur described hanging. So if you confirm @kibertoad I would uncomment the commented out codes, and we should merge it.

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[kibertoad]

@Uzlopak If I uncomment the test part, but do not uncomment the Dicer part, all tests still pass for me. It hangs for few seconds after execution, but still completes correctly.

[Uzlopak]

Exactly. It passes, despite it should fail. You have to uncomment the part in dicer to get the tests fail as expected.

[Uzlopak]

I use a red-green-blue approach. But here I dont get red phase, because the test itself cant handle the case.

---

I think we have to add done into mocha it and call done in the finish to be sure that we will hang.

[kibertoad]

Wait, so is the commented part in Dicer a reproduction or a fix :D?

[Uzlopak]

A fix. Now I have my red phase... So I can be sure, that the bug fix actually has impact.

[Uzlopak]

@ruur any comments?
@kibertoad it should be fixed now.

[Uzlopak]

@kibertoad
modified other unit tests to callback style where necessary to ensure we dont missed a bug.

[ruur]

LGTM