Update engines field #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fastify#89 support for Node.js 10 and 12 were dropped. It didn't explicitly mention a minimum version, but seems to be testing on the latest 14.x. I chose 14.13.1 since that is the minimum version of Node.js 14.x that Multer supports, and I would be very happy if this module would also support it.
Uzlopak
reviewed
Jun 8, 2022
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #89 support for Node.js 10 and 12 were dropped. It didn't explicitly mention a minimum version, but seems to be testing on the latest 14.x. I chose 14.13.1 since that is the minimum version of Node.js 14.x that Multer supports, and I would be very happy if this module would also support it.
Checklist
npm run testandnpm run benchmarkand the Code of conduct