Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid generation of intermediate array #598

Merged
merged 1 commit into from
Jan 23, 2023
Merged

avoid generation of intermediate array #598

merged 1 commit into from
Jan 23, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jan 23, 2023 •
edited
Loading

Well, the dependenciesName array is actually only needed for debug mode. Dont need that always

Checklist

mcollina
mcollina approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 394b315 into master Jan 23, 2023
@Uzlopak Uzlopak deleted the avoid-array branch January 23, 2023 12:28
Uzlopak added a commit that referenced this pull request Jan 24, 2023
@Uzlopak
avoid generation of intermediate array (#598)
56d087d
@renovate renovate bot mentioned this pull request Feb 25, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Uzlopak @mcollina