Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instead of global variables create context object and pass it as parameter #600

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jan 24, 2023

Properly encapsulate the whole state of the builder. Preparation for further changes like implementing a possible strict mode as discussed in #579

Checklist

@Uzlopak Uzlopak requested review from ivan-tymoshenko, Eomm and mcollina and removed request for ivan-tymoshenko January 24, 2023 11:20
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jan 24, 2023

I could have named it also state or so.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 33e1c3b into master Jan 24, 2023
@Uzlopak Uzlopak deleted the pass-context-around branch January 24, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants