Resolved Cannot convert a BigInt value to a number #723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
i was working on a project for a client and was using Prisma as an ORM. In my schema i was using BigInt as a value and everything was working fine until i upgraded to 5.15 of fast-json-stringify.
I then went and digged into your commits and found that you changed from
Number(i)
to+i
.This change broke my project causing 'Cannot convert a BigInt value to a number' when returing a big int from the database, and now i have to stay on version prior to 5.15.
Therefore i created this pr to revert that line of code back to Number(i) and everything works fine.
Hope this helps.
Let me know if you need more details!
ps: if you see an identical pull request it was because i used the wrong account!