Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(templates): remove obsolete .taprc file #747

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Conversation

faustman
Copy link
Contributor

Hi guys,

I'm recently playing with a new project and mentioned that you migrated from tap to node:assert, but .taprc is still in place.
This PR just removes unnecessary __taprc files from templates.

Thank you!

Checklist

Copy link
Contributor

@jean-michelet jean-michelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @faustman!

Code coverage and JIT transpiling are handled with c8 and ts-node:

test: 'npm run build:ts && tsc -p test/tsconfig.json && c8 node --test -r ts-node/register "test/**/*.ts"',

So lgtm (if the tests pass)!

@jean-michelet
Copy link
Contributor

These docs still refer to tap, can you update them please?

@faustman
Copy link
Contributor Author

I've updated README.
Can we run a test workflow, please?

@jean-michelet
Copy link
Contributor

Don't have the rights on this repo unfortunately.

Can you @mcollina?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@faustman
Copy link
Contributor Author

Thank you guys!
Everything looks fine, it's ready to merge)

@Eomm Eomm merged commit f55734c into fastify:master Jul 20, 2024
14 checks passed
@Eomm
Copy link
Member

Eomm commented Jul 20, 2024

relates to #682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants