fix: support for embedded cors for route params #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
reviewed
Nov 18, 2023
There was a problem hiding this comment.
I would mark it as a fix
Under the hood, the route registered was:
/:id*
and find my way does not support path parameter + wildcard like this.
Note that the preflight out of the /:id prefix, will not work anymore, still I think it is safe as preflight happens on the same context of other routes
Eomm
changed the title
Uzlopak
changed the title
Uzlopak
reviewed
Nov 18, 2023
| @@ -72,7 +72,7 @@ function fastifyCors (fastify, opts, next) { | |||
| // remove most headers (such as the Authentication header). | |||
| // | |||
| // This route simply enables fastify to accept preflight requests. | |||
| fastify.options('*', { schema: { hide: hideOptionsRoute } }, (req, reply) => { | |||
| fastify.options('/*', { schema: { hide: hideOptionsRoute } }, (req, reply) => { | |||
There was a problem hiding this comment.
when we register the url into find-my-way, we do:
prefix + url
so, in this case:
path param: "/:id" + "*" = "/:id*"
static prefix: "/foo" + "*" = "/foo*"
while the 2nd seems to work (but it can generate conflicts in any case), the first one does not work because it is a path parameter + a whilcard
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
Eomm
approved these changes
Nov 20, 2023
Uzlopak
approved these changes
Nov 20, 2023
|
Any plans of cutting a new release soon with this changes @Uzlopak ? |
|
Done, thanks for the ping |
renovate bot
added a commit
to tomacheese/telcheck
that referenced
this pull request
Dec 4, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/cors](https://togithub.com/fastify/fastify-cors) | [`8.4.1` -> `8.4.2`](https://renovatebot.com/diffs/npm/@fastify%2fcors/8.4.1/8.4.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-cors (@​fastify/cors)</summary> ### [`v8.4.2`](https://togithub.com/fastify/fastify-cors/releases/tag/v8.4.2) [Compare Source](https://togithub.com/fastify/fastify-cors/compare/v8.4.1...v8.4.2) #### What's Changed - build(dependabot): ignore tap major updates by [@​Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-cors#276 - fix: support for embedded cors for route params by [@​mohammedSlimani](https://togithub.com/mohammedSlimani) in [fastify/fastify-cors#278 #### New Contributors - [@​mohammedSlimani](https://togithub.com/mohammedSlimani) made their first contribution in [fastify/fastify-cors#278 **Full Changelog**: fastify/fastify-cors@v8.4.1...v8.4.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
4 tasks
climba03003
added a commit
that referenced
this pull request
Dec 17, 2023
This reverts commit 9acbafe.
4 tasks
mcollina
pushed a commit
that referenced
this pull request
Dec 18, 2023
This reverts commit 9acbafe.
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
Description of the bug:
When we try to set cors for a route that has route params, it seems that the cors plugin fails at registering the route and any calls to that route will return a 404 instead.