Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

use ascii instead of utf-8 #4

Closed
wants to merge 1 commit into from
Closed

use ascii instead of utf-8 #4

wants to merge 1 commit into from

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 29, 2022

writeEarlyHints on node uses ascii instead of utf-8. in node the strings get actually also validated by a regex. That regex is imho validating implicitly that it is ascii. Maybe we need to url_encode href to be sure we dont send garbage?

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 29, 2022

closing in favor of #5

@Uzlopak Uzlopak closed this Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants