Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added setting of methods for proxying #149

Merged
merged 4 commits into from
Apr 2, 2021
Merged

Added setting of methods for proxying #149

merged 4 commits into from
Apr 2, 2021

Conversation

udalyi-qs
Copy link
Contributor

@udalyi-qs udalyi-qs commented Apr 1, 2021 •
edited
Loading

Checklist

mcollina
mcollina requested changes Apr 1, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a unit test?

@udalyi-qs udalyi-qs requested a review from mcollina April 1, 2021 10:35
@mcollina
Copy link
Member

mcollina commented Apr 1, 2021

Can you add the option to https://github.com/fastify/fastify-http-proxy/blob/master/test/index.test-d.ts as well?

mcollina
mcollina reviewed Apr 2, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the continuous back-and-forth, I noticed this should be added to the README as well.

@udalyi-qs udalyi-qs requested a review from mcollina April 2, 2021 07:06
mcollina
mcollina approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit d6e4e92 into fastify:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@udalyi-qs @mcollina @mikhailudalyi