Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default and named export #170

Merged
merged 2 commits into from
Jul 22, 2021
Merged

feat: add default and named export #170

merged 2 commits into from
Jul 22, 2021

Conversation

climba03003
Copy link
Member

@climba03003 climba03003 commented Jul 22, 2021

Fixes: #169
add default and named export.

Checklist

@climba03003 climba03003 changed the title refactor: use fastify-plugin refactor: add default and named export Jul 22, 2021
@climba03003 climba03003 changed the title refactor: add default and named export feat: add default and named export Jul 22, 2021
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@climba03003
Copy link
Member Author

@mcollina should we consider this as minor or patch? both are suitable in my mind.
It fix the export and TypeScript mismatch problem.
It also provide more support on different import style.

@mcollina
Copy link
Member

patch is totally ok! Could you do the honors?

@climba03003
Copy link
Member Author

patch is totally ok! Could you do the honors?

Sure, I will release it as patch

@climba03003 climba03003 merged commit 13afbd6 into fastify:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin must be a function or a promise. TypeScript project.
2 participants