Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (types): update typescript definitions, typescript tests and harmonize directory structure #226

Merged
merged 4 commits into from
Jan 15, 2022
Merged

fix (types): update typescript definitions, typescript tests and harmonize directory structure #226

merged 4 commits into from
Jan 15, 2022

Conversation

darkgl0w
Copy link
Member

@darkgl0w darkgl0w commented Jan 14, 2022 •
edited
Loading

Hello.

This PR aims to :

  • fix a failing typescript definition test
  • update typescript definitions and tests
  • upgrade package dependencies
  • harmonize directory structure

Superseed #225, #221, #215

Checklist

@Fdawgs Fdawgs requested a review from a team January 14, 2022 22:03
climba03003
climba03003 approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mcollina
mcollina approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fdawgs Fdawgs merged commit d1a51a3 into fastify:master Jan 15, 2022
@darkgl0w darkgl0w deleted the typescript-errors branch January 15, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@climba03003 climba03003 climba03003 approved these changes

@Fdawgs Fdawgs Fdawgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@darkgl0w @mcollina @climba03003 @Fdawgs