Add tracking request-id example
#82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Mar 4, 2020
| server.register(proxy, { | ||
| upstream: 'http://localhost:4001', | ||
| replyOptions: { | ||
| rewriteRequestHeaders: (originalReq, headers) => ({...headers, 'request-id': uuid()}) |
There was a problem hiding this comment.
I think this might be a bit more complex than that. This example override the request-id, however we should 1) change the fastify id generator to use the unique id and 2) take it from req.id instead of generating a new one each time.
It would be really nice to have a unit test for this.
There was a problem hiding this comment.
The Fastify instance should be configured to read the request id from the incoming header. https://www.fastify.io/docs/v2.12.x/Server/#requestidheader
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an example with request tracking as discussed in #80
Checklist
npm run testandnpm run benchmark