feat: under-pressure integration #155
Conversation
index.js
Outdated
| @@ -5,6 +5,10 @@ const fp = require('fastify-plugin') | |||
| const Next = require('next') | |||
|
|
|||
| function fastifyNext (fastify, options, next) { | |||
| fastify.register(require('under-pressure'), options.underPressure) | |||
There was a problem hiding this comment.
We need to have an if to avoid installing this twice if it's already registered. We should also support underPressure: false to avoid adding it.
There was a problem hiding this comment.
ah yeah that makes sense. so under-pressure cannot be installed more than once? I thought it was possible to install it multiple times as long as the different registrations don't step on each other's feet.
having an option to disable it make sense to me. do you think it should be the default value? (of having it disabled I mean)
also 100% test coverage and other minor fixes
simoneb
force-pushed
the
under-pressure
branch
from
c918cc9
to
f478510
Compare
|
Updated the PR so that under-pressure is disabled by default and can be enabled using |
also 100% test coverage and other minor fixes
Checklist
npm run testandnpm run benchmarkand the Code of conduct