-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defaultStoreValues()
is sent the request
#157
Conversation
Fixes fastify#156 Signed-off-by: Pelle Wessman <pelle@kodfabrik.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test is missing
One question on this: In which of the three test files should tests preferably be added? There seems to be e2e tests that's run in both jest and tap? + non-e2e tests in jest? |
@voxpelli e2e is preferable |
@kibertoad Should it be added in both the jest and tap ones then? I see that tap tests were added in #50 since jest tests were failing, now they all pass for me locally at least |
@voxpelli yeah, jest problem was fixed later. either of them or both would be good, I would err on the side of more jest tests |
@kibertoad Tests added |
Thank you! |
This PR fixes #156 by adding the current request instance as a parameter to the
defaultStoreValues()
factoryChecklist
npm run test
and(does not exist on this project)npm run benchmark
and the Code of conduct