Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of dotfiles property #168

Merged
merged 5 commits into from
Jan 5, 2021
Merged

Fix type of dotfiles property #168

merged 5 commits into from
Jan 5, 2021

Conversation

MSE99
Copy link
Contributor

@MSE99 MSE99 commented Jan 5, 2021

Checklist

Note

Fixes #165

@zekth
Copy link
Member

zekth commented Jan 5, 2021

can you add test for dotfile? thanks

@mcollina
Copy link
Member

mcollina commented Jan 5, 2021

@MSE99
Copy link
Contributor Author

MSE99 commented Jan 5, 2021

The CI failed, it's because the tests failed due to the fact i tried to dynamically add an .example file for each test (it worked and the tests passed on my local machine) i did this because i didn't want to conflict with the last pull request since adding a file to the static directory will require editing other test, since this branch is behind master can i merge the changes from master into it and just manually add the .example file into the static directory ?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for adding the tests

@mcollina mcollina merged commit 18db09c into fastify:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type for option dotfiles
3 participants