test: add some coverage (#2662)

* test: cover passing backlog as second last arg to listen * refactor: remove unnecessary elseif
fastify · Nov 9, 2020 · c16f74b · c16f74b
1 parent 1175777
commit c16f74b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/fastify.js b/fastify.js
@@ -60,16 +60,16 @@ const onBadUrlContext = {
 }
 
 function defaultErrorHandler (error, request, reply) {
-  if (reply.statusCode >= 500) {
-    reply.log.error(
-      { req: request, res: reply, err: error },
-      error && error.message
-    )
-  } else if (reply.statusCode >= 400) {
+  if (reply.statusCode < 500) {
     reply.log.info(
       { res: reply, err: error },
       error && error.message
     )
+  } else {
+    reply.log.error(
+      { req: request, res: reply, err: error },
+      error && error.message
+    )
   }
   reply.send(error)
 }

diff --git a/test/listen.test.js b/test/listen.test.js
@@ -62,6 +62,18 @@ test('listen accepts options and a callback', t => {
   })
 })
 
+test('listen accepts options, backlog and a callback', t => {
+  t.plan(1)
+  const fastify = Fastify()
+  t.tearDown(fastify.close.bind(fastify))
+  fastify.listen({
+    port: 0,
+    host: 'localhost'
+  }, 511, (err) => {
+    t.error(err)
+  })
+})
+
 test('listen accepts a port, address and a callback with (err, address)', t => {
   t.plan(2)
   const fastify = Fastify()