-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to avvio@7.0.0-alpha.0 #2093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will there be a "final" release before v3? Maybe we should have an automated audit during a release stage to prohibit pre-release modules in the dependencies and warn for non-semver major ones?
@jsumners I think we should plan the release for v3 with some caution. I'm thinking to have some -alpha releases and a few release candidates. We can then update the modules. I would lean to do a semver-major change everywhere because I think we should drop old Node.js versions anyway. |
I agree. I just want to make sure we don't release a final v3 with release candidate tagged dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would write more extensive documentation and add some more test, we are not covering await fastify.register
at the moment.
docs/Server.md
Outdated
console.log('After current plugin') | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover :)
I've added a test for @delvedor which kind of doc would you like to see? I struggled a bit in finding a good place where to add more. I would like to land this ASAP so we can unblock all the other PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's open an issue for this bug and another one for improving the documentation.
People will likely use async-await a lot, and we should do better work on showing examples of how to use it.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Update to avvio@7, implementing
await app.register()
andawait app.after()
.Checklist
npm run test
andnpm run benchmark