change *compiler api #2179
Merged
change *compiler api #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
added
semver-major
jsumners
reviewed
Apr 5, 2020
|
applied @jsumners suggestion 馃憤 |
mcollina
requested changes
Apr 12, 2020
jsumners
approved these changes
Apr 12, 2020
This was referenced Jun 15, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to change the new API interface for *compilers, this would ease the migration from v2 to v3.
I thought it was a good idea to put the
schemaat the end... 馃槄Edit:
the target is that the migration would be: "replace
setSchemaCompiler()tosetValidatorCompiler()"cc #2140
Checklist
npm run testandnpm run benchmark