add startup benchmark #2195
add startup benchmark #2195
Conversation
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
| schema[field] = built | ||
| } | ||
| return schema | ||
| }, {}) |
There was a problem hiding this comment.
There are currently 2 fields and there is an if for one of them. Could you please remove the reduce?
| schema.prop(`random-${prop}-${Math.round(Math.random() * 1000)}`, typeGen.next().value) | ||
| } | ||
|
|
||
| const built = schema.valueOf() |
There was a problem hiding this comment.
Should fluent-schema be part of the bench?
There was a problem hiding this comment.
I would avoid testing fluent-schema also since not all the users use it and it could impact the results (a little bit)
| return lastSchema | ||
| } | ||
|
|
||
| function * getSchemaType () { |
|
Please rebase this pr against the new |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Dear stalebot, I will complete this PR soon 🤣 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Starting from #2179 : it would be interesting adding a startup bench to check improvements to this phase. For example, I'm really curious to verify in
nextthe changes made on the validation flow since the boost exists only in theory right now.This is a quick demo that generates random schemas as the worst case in the universe, but we should define a set of "common used" schemas to tests, so I think we should define these tests:
bodyandYforresponseusing shared schemabodyandYforresponsewithout using shared schemaWDYT?
Checklist
npm run testandnpm run benchmark