Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete unreachable branch #2539

Merged
merged 1 commit into from
Sep 7, 2020
Merged

fix: delete unreachable branch #2539

merged 1 commit into from
Sep 7, 2020

Conversation

zekth
Copy link
Member

@zekth zekth commented Sep 7, 2020

Was stumbling upon improving code coverage and this branch is unreachable:
https://github.com/fastify/fastify/blob/master/lib/request.js#L33
Because of this condition:
https://github.com/fastify/fastify/blob/master/lib/request.js#L37

So it makes sense to replace .compile(tp || [] ) with compile(tp)

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 31b7c4f into fastify:master Sep 7, 2020
@zekth zekth deleted the add_tests branch September 7, 2020 10:47
@Eomm Eomm added the test Issue or pr related to our testing infrastructure. label Sep 7, 2020
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test Issue or pr related to our testing infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants