Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encapsulation reference doc #2724

Merged
merged 3 commits into from
Dec 6, 2020
Merged

Add encapsulation reference doc #2724

merged 3 commits into from
Dec 6, 2020

Conversation

jsumners
Copy link
Member

@jsumners jsumners commented Dec 6, 2020

We keep having to answer questions about Fastify's encapsulation feature because we do not currently explain it thoroughly in our reference documentation. This PR solves that issue.

Checklist

@jsumners jsumners requested a review from a team December 6, 2020 13:50
docs/Encapsulation.md Outdated Show resolved Hide resolved
docs/Encapsulation.md Outdated Show resolved Hide resolved
docs/Encapsulation.md Outdated Show resolved Hide resolved
docs/Encapsulation.md Outdated Show resolved Hide resolved
docs/Encapsulation.md Outdated Show resolved Hide resolved
docs/Encapsulation.md Outdated Show resolved Hide resolved
docs/Encapsulation.md Outdated Show resolved Hide resolved
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Good way to explain how to properly separate authenticated / non authenticated routes

@jsumners jsumners merged commit 663e823 into master Dec 6, 2020
@jsumners jsumners deleted the encapsulation-docs branch December 6, 2020 15:23
@kibertoad
Copy link
Member

@jsumners BTW, new article does not show up on https://www.fastify.io/docs/latest/
I assume TOC needs to be updated as well?

@jsumners
Copy link
Member Author

@kibertoad I put it in /README.md.

@lmammino how does this file get included?

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants