-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorthand bypass flag (required to implement JTD and other schema formats support) #3156
Conversation
Co-authored-by: James Sumners <james@sumners.email>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment for documentation format consistency.
Co-authored-by: Vincent LE GOFF <vince.legoff@gmail.com>
Co-authored-by: Vincent LE GOFF <vince.legoff@gmail.com>
I removed the JTD tests at Eomm's suggestion, since they were only loosely coupled, relying on external dependencies, and I now believe don't make sense in this specific PR, as I mentioned in the comments.
|
Co-authored-by: Vincent LE GOFF <vince.legoff@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Eomm could you please take a final look before landing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the JTD tests at Eomm's suggestion, since they were only loosely coupled, relying on external dependencies, and I now believe don't make sense in this specific PR, as I mentioned in the comments.
thanks @josh-hemphill
The commit history will be helpful for the jtd anyway 👍🏽
We have explored that this is doable in this way
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Prerequisite for further JTD Schema integration
It allows users that need it, to manually substitute a JTD instance of AJV into instances of Fastify, or create a ValidatorCompiler that parses anything other than JSON Schema, by preventing Fastify from mutating schemas internally if they don't match JSON Schema root properties.
The result of the work on #3096 but PRed against main.
Related #3083
Checklist
npm run test
andnpm run benchmark
and the Code of conduct