-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add node 17 #3456
add node 17 #3456
Conversation
The error on node17 (and locally can't replicate)
Cannot find any breaking change that should impact the server IP listening interface https://nodejs.org/en/blog/release/v17.0.0/ 🤔 |
Was searching for the same changes and stumbled upon this issue: nodejs/node#40537 Seems like there is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need test fixes
This should be good to land now, tests pass locally. Let's double check it. |
cc @targos this the the PR I was talking about. |
This PR should close #3428 too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
superseded #3381
Closes #3456